Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #6354 - allow jetty bundles to use 1.7 slf4j #6356

Merged
merged 1 commit into from Jun 3, 2021
Merged

Fixes #6354 - allow jetty bundles to use 1.7 slf4j #6356

merged 1 commit into from Jun 3, 2021

Conversation

tjwatson
Copy link
Contributor

@tjwatson tjwatson commented Jun 3, 2021 •
edited

No description provided.

@tjwatson
Fixes jetty#6354 - allow jetty bundles to use 1.7 slf4j
256ee34 
This updates the parent pom to set the range for all
imports of slf4j by the jetty bundles

Signed-off-by: Thomas Watson <tjwatson@us.ibm.com>
@joakime
Copy link
Contributor

joakime commented Jun 3, 2021

Seems pretty straight forward, I'm going to wait to see if the osgi build/test portions of CI pass.

@joakime joakime requested a review from janbartel June 3, 2021 15:20
@joakime joakime added this to In progress in Jetty 10.0.3/11.0.3 via automation Jun 3, 2021
@joakime joakime removed this from In progress in Jetty 10.0.3/11.0.3 Jun 3, 2021
@joakime joakime added this to In progress in Jetty 10.0.4/11.0.4 FROZEN via automation Jun 3, 2021
@joakime joakime linked an issue Jun 3, 2021 that may be closed by this pull request
org.slf4j dependency imports osgi packages at 2.0 #6354
Closed
Jetty 10.0.4/11.0.4 FROZEN automation moved this from In progress to Reviewer approved Jun 3, 2021
joakime
joakime approved these changes Jun 3, 2021
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is happy.
And some local testing of this PR shows that this change seems to propagate to child modules nicely. (manually cracked open a few select jars and looked at the generated manifest)

@joakime joakime merged commit fbbe584 into jetty:jetty-10.0.x Jun 3, 2021
Jetty 10.0.4/11.0.4 FROZEN automation moved this from Reviewer approved to Done Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@janbartel janbartel Awaiting requested review from janbartel

Assignees
No one assigned
Labels
Enhancement
Projects
No open projects
Jetty 10.0.4/11.0.4 FROZEN
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

org.slf4j dependency imports osgi packages at 2.0
2 participants
@tjwatson @joakime