Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6302 - Treat empty path segments as ambiguous. #6304

Merged
merged 13 commits into from Jun 10, 2021
Merged

Issue #6302 - Treat empty path segments as ambiguous. #6304

merged 13 commits into from Jun 10, 2021

Commits on May 20, 2021

  1. Issue #6302 - Treat empty path segments are ambiguous. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 20, 2021
    Configuration menu
    Copy the full SHA
    36332ab View commit details
    Browse the repository at this point in the history

Commits on May 21, 2021

  1. Fix false empty segments being reported + changes from review. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 21, 2021
    Configuration menu
    Copy the full SHA
    c30875e View commit details
    Browse the repository at this point in the history

Commits on May 23, 2021

  1. Fix broken test + improve comments. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 23, 2021
    Configuration menu
    Copy the full SHA
    3206dab View commit details
    Browse the repository at this point in the history

Commits on May 25, 2021

  1. Add HttpUriTests for the empty segment as ambiguous 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 25, 2021
    Configuration menu
    Copy the full SHA
    3aec963 View commit details
    Browse the repository at this point in the history

  2. Issue #63002 - Only call checkSegment() for real empty segments. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 25, 2021
    Configuration menu
    Copy the full SHA
    0cae7bf View commit details
    Browse the repository at this point in the history

  3. Issue #63002 - Empty segments are only ambiguous if followed by a '#'… 

    …, '?' or end of string

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 25, 2021
    Configuration menu
    Copy the full SHA
    2649182 View commit details
    Browse the repository at this point in the history

Commits on May 27, 2021

  1. If only the last segment is empty it is not ambiguous. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 27, 2021
    Configuration menu
    Copy the full SHA
    2792217 View commit details
    Browse the repository at this point in the history

Commits on May 28, 2021

  1. improve testing for path HttpUri pathQuery() 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 28, 2021
    Configuration menu
    Copy the full SHA
    3dd5460 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2021

  1. Add javadoc for HttpURI.Ambiguous 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 31, 2021
    Configuration menu
    Copy the full SHA
    93eaffd View commit details
    Browse the repository at this point in the history

  2. Add decodedPath to testPathQuery() expectations. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed May 31, 2021
    Configuration menu
    Copy the full SHA
    918f377 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2021

  1. Change comments, add some extra tests. 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Jun 8, 2021
    Configuration menu
    Copy the full SHA
    339e245 View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2021

  1. Update jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java

    @gregw
    gregw committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    26d1646 View commit details
    Browse the repository at this point in the history

  2. Update jetty-http/src/main/java/org/eclipse/jetty/http/HttpURI.java 

    better examples
    @gregw
    gregw committed Jun 10, 2021
    Configuration menu
    Copy the full SHA
    ceccab9 View commit details
    Browse the repository at this point in the history