Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6277 Better handling of exceptions thrown in sessionDestroyed … #6279

Merged

Conversation

janbartel
Copy link
Contributor

Cherry-pick from 10.0.x back to 9.4.x for fix for #6277

…6278)

* Issue #6277 Better handling of exceptions thrown in sessionDestroyed

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel requested a review from gregw May 16, 2021 00:06
@janbartel janbartel self-assigned this May 16, 2021
@janbartel janbartel added this to In progress in Jetty 9.4.41 via automation May 16, 2021
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Jetty 9.4.41 automation moved this from In progress to Reviewer approved May 16, 2021
@janbartel janbartel merged commit 087f486 into jetty-9.4.x May 16, 2021
Jetty 9.4.41 automation moved this from Reviewer approved to Done May 16, 2021
@janbartel janbartel deleted the jetty-9.4.x-6277-session-destroy-listener-exceptions branch May 16, 2021 07:32
@Override
public void sessionDestroyed(HttpSessionEvent se)
{
throw new IllegalStateException("Exception during sessionDestroyed");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should test a Throwable as well.
perhaps something like ... javax.xml.parsers.FactoryConfigurationError ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants