Fixes #6251 - Use CyclicTimeout for HTTP2Streams. #6267
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Introduced CyclicTimeouts to manage many entities that may timeout. Rewritten HttpDestination request timeouts using CyclicTimeouts. HTTP2Stream does not inherit from IdleTimeout anymore; now a CyclicTimeouts in HTTP2Session manages the stream timeouts. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
May 13, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/CyclicTimeouts.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/CyclicTimeouts.java
Outdated
Show resolved
Hide resolved
Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
previously approved these changes
May 13, 2021
Fixed javadocs. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
May 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced CyclicTimeouts to manage many entities that may timeout.
Rewritten HttpDestination request timeouts using CyclicTimeouts.
HTTP2Stream does not inherit from IdleTimeout anymore; now a
CyclicTimeouts in HTTP2Session manages the stream timeouts.
Signed-off-by: Simone Bordet simone.bordet@gmail.com