Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 9.4 - Review URI encoding in ConcatServlet & WelcomeFilter and improve testing #6261

Merged
merged 2 commits into from May 12, 2021
Merged

Jetty 9.4 - Review URI encoding in ConcatServlet & WelcomeFilter and improve testing #6261

merged 2 commits into from May 12, 2021

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented May 12, 2021 •
edited

Issue #6263

  • Review of the URI encoding with regards to RequestDispatcher usage.
  • Improvements to testing for ConcatServlet and UpgradeFilter.

@lachlan-roberts
Review URI encoding in ConcatServlet & WelcomeFilter and improve test…
c704b81 
…ing.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw previously approved these changes May 12, 2021
View reviewed changes
@lachlan-roberts lachlan-roberts linked an issue May 12, 2021 that may be closed by this pull request
Review URI encoding in ConcatServlet & WelcomeFilter #6263
Closed
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 9.4.41 via automation May 12, 2021
@sbordet
Issue #6263 - Review URI encoding in ConcatServlet & WelcomeFilter.
5d57248 
Fixed log statement.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
Jetty 9.4.41 automation moved this from In progress to Review in progress May 12, 2021
@sbordet sbordet self-requested a review May 12, 2021 14:11
Jetty 9.4.41 automation moved this from Review in progress to Reviewer approved May 12, 2021
@sbordet sbordet merged commit 1c05b0b into jetty-9.4.x May 12, 2021
Jetty 9.4.41 automation moved this from Reviewer approved to Done May 12, 2021
@sbordet sbordet deleted the jetty-9.4.x-UriEncodingReview branch May 12, 2021 15:13
This was referenced Mar 4, 2022
Closed
Closed
Closed
This was referenced Sep 20, 2022
Closed
Closed
Closed
@cxronen cxronen mentioned this pull request Dec 20, 2022
Open
@cxronen cxronen mentioned this pull request Feb 17, 2023
Open
@cxronen cxronen mentioned this pull request Nov 22, 2022
Open
This was referenced Feb 26, 2023
Open
Open
Open
@cxronen cxronen mentioned this pull request Mar 15, 2023
Open
This was referenced Feb 15, 2023
Open
Open
This was referenced Apr 26, 2023
Open
Open
@AASMACMX AASMACMX mentioned this pull request Apr 26, 2023
Open
@cxronen cxronen mentioned this pull request May 25, 2023
Open
This was referenced Jul 10, 2023
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@gregw gregw gregw left review comments

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.41
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Review URI encoding in ConcatServlet & WelcomeFilter
3 participants
@lachlan-roberts @gregw @sbordet