Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Copy ServletHolder class/instance properly during startWebapp #6214

Merged
merged 10 commits into from May 16, 2021
Merged

Copy ServletHolder class/instance properly during startWebapp #6214

merged 10 commits into from May 16, 2021

Commits on Apr 21, 2021

  1. Attempt to replicate bug reported against precompiled jsps in descrip… 

    …tor.

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 21, 2021
    Copy the full SHA
    ca82dde View commit details
    Browse the repository at this point in the history

Commits on Apr 22, 2021

  1. Speculative ServletHolder.copyClassServlet() method added. 

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 22, 2021
    Copy the full SHA
    0032484 View commit details
    Browse the repository at this point in the history

  2. Adding System/Server ClasspathPattern fix 

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 22, 2021
    Copy the full SHA
    4424bfc View commit details
    Browse the repository at this point in the history

  3. Updating testcase to eliminate false success. 

    - using status code 555 for testcase
  eliminating 503 false success
  from different code path than
  what we are attempting to fix

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 22, 2021
    Copy the full SHA
    0d95ef6 View commit details
    Browse the repository at this point in the history

  4. Updating testcase to fix issue. 

    - ServletHolder needs a mapping
  to allow RejectUncompiledJspServlet
  to respond to requests for JSPs
  that haven't been precompiled.
- Precompiled test class is now
  properly placed into a generated
  webapp base directory without
  contaminating the webapp classloader
  with other src/test/java classes

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 22, 2021
    Copy the full SHA
    4dbb146 View commit details
    Browse the repository at this point in the history

Commits on Apr 27, 2021

  1. Copy just the class 

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Apr 27, 2021
    Copy the full SHA
    6df2cf2 View commit details
    Browse the repository at this point in the history

Commits on Apr 28, 2021

  1. Simplified test 

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Apr 28, 2021
    Copy the full SHA
    ce3df58 View commit details
    Browse the repository at this point in the history

  2. Simplified test 

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Apr 28, 2021
    Copy the full SHA
    c29cb55 View commit details
    Browse the repository at this point in the history

  3. Minor cleanup to reduce noisy parts of test 

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    @joakime
    joakime committed Apr 28, 2021
    Copy the full SHA
    f8f8be6 View commit details
    Browse the repository at this point in the history

Commits on May 15, 2021

  1. update from review 

    use inner classes

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed May 15, 2021
    Copy the full SHA
    2239740 View commit details
    Browse the repository at this point in the history