Updated Deployment Not enabled console message #6182
Conversation
…ons to turn on and change redeployment status
| @@ -144,7 +144,7 @@ private void startScanner() | |||
| { | |||
| if (scan < 0) | |||
| { | |||
| getLog().info("Redeployment not enabled"); | |||
| getLog().info("Redeployment Disabled; Default Scan Interval = -1 ; Change Value to <scan>0<scan> for Manual or <scan>${Seconds}<scan> for automatic "); | |||
There was a problem hiding this comment.
Thanks for the pull request, I understand you're looking for more configuration info (which is in the doco btw). I think this log line might be a little wordy, how about something a bit more in line with the other configuration summaries the plugin produces, that is a little more succinct like:
"scan=-1 redeploy disabled (scan=0:redeploy on ENTER; scan > 0:automatic redeploy check sec)"
There was a problem hiding this comment.
I would like to see the word default because there is now behaviour change in this later version 11.0.2 compare to earlier versions with manual deploy was the default.
Good user experience is where there is immediate cause and solution rather than having to look at documents, In my opinion.
default scan=-1:redeploy disabled; scan=0:redeploy manual on ENTER; scan > 0:redeploy automatic
There was a problem hiding this comment.
default deploy mode scan=-1:redeploy disabled; scan=0:redeploy manual on ENTER; scan > 0:redeploy automatic
I am happy with this. The default also may alert the user that there is other functionality available.
Hot Deploy is a very useful feature, even a hyped! feature in some circles, needs to be brought to the forefront attention of the user.
The user being a developer he will know implications into with word default.
I did not suggest a changing the default behaviour because I am sure you had a good reason for it.
Personally my preference is default mode to be manual deploy mode.
may be add the word " default deploy mode" also with default ?
|
Some info for you: we just changed the default a few weeks ago. Previously all versions of jetty were no redeploy by default. With 10.0.0/11.0.0 we changed it to manual redeploy by default, and then we changed it back again to no redeploy for 11.0.2 with this issue #6020. +1 if you want to use the word "default" in the message. |
|
Closed in favour of other PR #6188 |
Updated Deployment console message for a clearer status and instructions to turn on and change redeployment status for better user experience in
jetty-maven-plugin/src/main/java/org/eclipse/jetty/maven/plugin/JettyRunMojo.java