Fixes #6105 - HttpConnection.getBytesIn() incorrect for requests with… #6108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… chunked content Moved recording of bytes to fillRequestBuffer(), so they are accounted also for async reads. Added test case. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
… chunked content Fixed test that was too strictly comparing HttpConnection.bytesIn, that now report a correct, but larger value. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
requested changes
Mar 29, 2021
jetty-server/src/test/java/org/eclipse/jetty/server/HttpConnectionTest.java
Show resolved
Hide resolved
gregw
approved these changes
Mar 31, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… chunked content
Moved recording of bytes to fillRequestBuffer(),
so they are accounted also for async reads.
Added test case.
Signed-off-by: Simone Bordet simone.bordet@gmail.com