Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6085 Fix reference counts for multiple valid cookies for sessions #6096

Merged
merged 1 commit into from Mar 24, 2021
Merged

Issue #6085 Fix reference counts for multiple valid cookies for sessions #6096

merged 1 commit into from Mar 24, 2021
+34 −14

Conversation

janbartel
Copy link
Contributor

@janbartel janbartel commented Mar 24, 2021 •
edited

cherry pick from 9.4.x

issue #6085

@janbartel
Issue #6085 Fix reference counts for multiple valid cookies for sessi…
20dd419 
…ons (#6088)

* Issue #6085 Fix reference counts for multiple valid cookies for sesssions

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel self-assigned this Mar 24, 2021
lorban
lorban approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is literally identical to #6088 so LGTM.

sbordet
sbordet previously approved these changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kinda looks ok, but I think it could be improved by making the enterSession() and setSession() calls in consecutive lines, like it is done in other places.

jetty-server/src/main/java/org/eclipse/jetty/server/session/SessionHandler.java Show resolved Hide resolved
@sbordet sbordet dismissed their stale review March 24, 2021 16:56

I changed my mind

@sbordet sbordet self-requested a review March 24, 2021 16:56
sbordet
sbordet requested changes Mar 24, 2021
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment.

@janbartel janbartel requested a review from sbordet March 24, 2021 20:58
@gregw gregw added this to In progress in Jetty 10.0.2/11.0.2 via automation Mar 24, 2021
Jetty 10.0.2/11.0.2 automation moved this from In progress to Reviewer approved Mar 24, 2021
@janbartel janbartel merged commit fd05a3d into jetty-10.0.x Mar 24, 2021
Jetty 10.0.2/11.0.2 automation moved this from Reviewer approved to Done Mar 24, 2021
@janbartel janbartel deleted the jetty-10.0.x-6085-duplicate-valid-jsessionid-cookies branch March 24, 2021 22:37
@gregw gregw linked an issue Mar 25, 2021 that may be closed by this pull request
Jetty keeps Sessions in use after "Duplicate valid session cookies" Message #6085
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw left review comments

@sbordet sbordet sbordet approved these changes

@lorban lorban lorban approved these changes

Assignees

@janbartel janbartel

Labels
None yet
Projects
No open projects
Jetty 10.0.2/11.0.2
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Jetty keeps Sessions in use after "Duplicate valid session cookies" Message
4 participants
@janbartel @gregw @sbordet @lorban