Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #6085 Fix reference counts for multiple valid cookies for sessions #6088

Merged

Conversation

janbartel
Copy link
Contributor

Closes #6085

If a request has multiple session cookies, and the sessions for more than one of them are valid, then the request counts for the valid sessions were not being properly decremented.

…ions

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel requested a review from gregw March 23, 2021 23:41
@janbartel janbartel added this to In progress in Jetty 9.4.38 via automation Mar 23, 2021
@janbartel janbartel self-assigned this Mar 23, 2021
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK other than some niggles.
There is some repeated logic, but I can't see how to clean it up without risking changing behaviour.

Jetty 9.4.38 automation moved this from In progress to Reviewer approved Mar 24, 2021
janbartel and others added 2 commits March 24, 2021 11:12
…ssionHandler.java

Co-authored-by: Greg Wilkins <gregw@webtide.com>
…ssionHandler.java

Co-authored-by: Greg Wilkins <gregw@webtide.com>
@janbartel janbartel merged commit 6d8ae9c into jetty-9.4.x Mar 24, 2021
Jetty 9.4.38 automation moved this from Reviewer approved to Done Mar 24, 2021
@janbartel janbartel deleted the jetty-9.4.x-6085-duplicate-valid-jsessionid-cookies branch March 24, 2021 02:31
janbartel added a commit that referenced this pull request Mar 24, 2021
…ons (#6088)

* Issue #6085 Fix reference counts for multiple valid cookies for sesssions

Signed-off-by: Jan Bartel <janb@webtide.com>
janbartel added a commit that referenced this pull request Mar 24, 2021
…ons (#6088) (#6096)

* Issue #6085 Fix reference counts for multiple valid cookies for sesssions

Signed-off-by: Jan Bartel <janb@webtide.com>
@gregw gregw removed this from Done in Jetty 9.4.38 Mar 25, 2021
@olamy olamy added this to Done in Jetty 9.4.39 Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants