Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6063 - expose hazelcast.version #6064

Merged
merged 1 commit into from Mar 24, 2021
Merged

Issue #6063 - expose hazelcast.version #6064

merged 1 commit into from Mar 24, 2021
+12 −5

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Mar 15, 2021

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

@joakime
Issue #6063 - expose hazelcast.version
283be1b 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested a review from olamy March 15, 2021 18:56
@joakime joakime self-assigned this Mar 15, 2021
@joakime joakime added this to In progress in Jetty 9.4.38 via automation Mar 15, 2021
@joakime joakime moved this from In progress to Review in progress in Jetty 9.4.38 Mar 15, 2021
@joakime joakime linked an issue Mar 15, 2021 that may be closed by this pull request
Allow override of hazelcast version when using module #6063
Closed
olamy
olamy approved these changes Mar 16, 2021
View reviewed changes
Copy link
Member

@olamy olamy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (grhh 2 more mod files with this usage! :) )

Jetty 9.4.38 automation moved this from Review in progress to Reviewer approved Mar 16, 2021
@gregw gregw requested a review from janbartel March 23, 2021 21:14
@olamy olamy merged commit 1154f2e into jetty-9.4.x Mar 24, 2021
Jetty 9.4.38 automation moved this from Reviewer approved to Done Mar 24, 2021
@olamy olamy deleted the jetty-9.4.x-6063-hazelcast.version branch March 24, 2021 23:23
olamy pushed a commit that referenced this pull request Mar 24, 2021
@joakime @olamy
Issue #6063 - expose hazelcast.version (#6064)
8ab7a8f 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@olamy olamy removed this from Done in Jetty 9.4.38 Mar 25, 2021
@olamy olamy added this to Done in Jetty 9.4.39 Mar 25, 2021
@janbartel janbartel mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olamy olamy olamy approved these changes

@janbartel janbartel janbartel approved these changes

Assignees

@joakime joakime

Labels
Enhancement
Projects
No open projects
Jetty 9.4.39
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow override of hazelcast version when using module
3 participants
@joakime @olamy @janbartel