Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #6008 - fix RequestLog usage with filePath. #6033

Merged
merged 3 commits into from Mar 11, 2021
Merged

Issue #6008 - fix RequestLog usage with filePath. #6033

merged 3 commits into from Mar 11, 2021

Conversation

lachlan-roberts
Copy link
Contributor

Closes #6008

Restore the previous usage of the jetty.requestlog.filePath property which was broken with #6022.

@lachlan-roberts
Issue #6008 - fix RequestLog usage with filePath.
08c4ce1 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts mentioned this pull request Mar 4, 2021
Closed
joakime
joakime requested changes Mar 4, 2021
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The mod changes don't seem to be necessary.

jetty-server/src/main/config/modules/requestlog.mod Show resolved Hide resolved
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 10.0.2/11.0.2 via automation Mar 8, 2021
@lachlan-roberts lachlan-roberts moved this from In progress to Review in progress in Jetty 10.0.2/11.0.2 Mar 8, 2021
@lachlan-roberts
Issue #6008 - changes from review
c1215e4 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw requested changes Mar 9, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you were right to try to fix this. Leaving it as is is not great.

I think just removing the reference in the comment is OK. Using the ?= is mostly OK.
So pick one and I'll approve either this time.

@lachlan-roberts
Issue #6008 - add default ini line for jetty.requestlog.dir
671a76c 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts merged commit c664d67 into jetty-10.0.x Mar 11, 2021
Jetty 10.0.2/11.0.2 automation moved this from Review in progress to Done Mar 11, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-10.0.x-6008-RequestLogFix branch March 11, 2021 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime Awaiting requested review from joakime

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 10.0.2/11.0.2
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow absolute paths to be provided in start.ini for request log directory.
3 participants
@lachlan-roberts @gregw @joakime