New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix #5835 Durable filters and servlets #6027
Conversation
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup
@janbartel nudge |
@janbartel re-nudge |
|
||
_matchAfterIndex = (_filterMappings.length == 0 ? -1 : _filterMappings.length - 1); | ||
// Update indexes for prepending filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any code here that removes the non-durable filtermappings, yet we've set the matchBefore and matchAfter index.
update indexes after updating mapping Signed-off-by: Greg Wilkins <gregw@webtide.com>
update mappings/indexes before destroyed listeners Signed-off-by: Greg Wilkins <gregw@webtide.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If CI is happy, then ship it!
Fix #5835 Durable filters and servlets with a general ServletHandler cleanup.
This replaces #5837