Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5996 - Remove logback-access.mod #6002

Merged
merged 3 commits into from Mar 24, 2021

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Feb 23, 2021

  • Remove logback-access.mod (and associated files) as it doesn't work with Jetty 10+

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

+ Moved to /jetty-home/ to align with other logging type modules
+ Correct dependencies

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added the Bug For general bugs on Jetty side label Feb 23, 2021
@joakime joakime self-assigned this Feb 23, 2021
@joakime joakime added this to In progress in Jetty 10.0.2/11.0.2 via automation Feb 23, 2021
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime changed the title Issue #5996 - cleanup logback-access.mod Issue #5996 - Remove logback-access.mod Feb 23, 2021
Jetty 10.0.2/11.0.2 automation moved this from In progress to Review in progress Feb 24, 2021
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are we removing logback-access?
I understand it doesn't work, but shouldn't we just make it work???

@joakime
Copy link
Contributor Author

joakime commented Feb 24, 2021

Why are we removing logback-access?
I understand it doesn't work, but shouldn't we just make it work???

We would have to re-break the Response.getHttpFields() method, and the HttpFields object itself to be compatible with the way it is in Jetty 9.4.x

@joakime joakime requested a review from gregw March 10, 2021 12:26
Jetty 10.0.2/11.0.2 automation moved this from Review in progress to Reviewer approved Mar 24, 2021
@gregw gregw merged commit cba4864 into jetty-10.0.x Mar 24, 2021
Jetty 10.0.2/11.0.2 automation moved this from Reviewer approved to Done Mar 24, 2021
@gregw gregw deleted the jetty-10.0.x-5996-bad-logback-access-module branch March 24, 2021 02:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

ERROR : No module found to provide logback-impl for logback-access{enabled}
2 participants