Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

More optional etag gzip fixes for #5979 #5986

Merged
merged 2 commits into from Feb 18, 2021
Merged

More optional etag gzip fixes for #5979 #5986

merged 2 commits into from Feb 18, 2021

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Feb 18, 2021

More optional etag gzip fixes for #5979
If no separator defined, do not add a suffix to an etag.
Some cleanup of the implementation.

@gregw
More optional etag gzip fixes for #5979
7d28b42 
IF no separator defined, do not add a suffix to an etag.
Some cleanup of the implementation.
@gregw gregw requested a review from sbordet February 18, 2021 09:55
@gregw gregw added the Sponsored This issue affects a user with a commercial support agreement label Feb 18, 2021
@gregw gregw added this to In progress in Jetty 9.4.37 via automation Feb 18, 2021
@sbordet sbordet changed the base branch from jetty-10.0.x to jetty-9.4.x February 18, 2021 11:42
Jetty 9.4.37 automation moved this from In progress to Review in progress Feb 18, 2021
sbordet
sbordet requested changes Feb 18, 2021
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly good, but fix the compilation issues and maybe little more javadocs.

jetty-http/src/main/java/org/eclipse/jetty/http/CompressedContentFormat.java Show resolved Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/CompressedContentFormat.java Show resolved Hide resolved
jetty-http/src/main/java/org/eclipse/jetty/http/PrecompressedHttpContent.java Outdated Show resolved Hide resolved
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/GzipHandlerTest.java Outdated Show resolved Hide resolved
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/GzipHandlerTest.java Outdated Show resolved Hide resolved
jetty-servlets/src/test/java/org/eclipse/jetty/server/handler/gzip/GzipDefaultTest.java Outdated Show resolved Hide resolved
@sbordet
Copy link
Contributor

sbordet commented Feb 18, 2021

@gregw you made a PR based on 10.0.x, but I changed it to be based on 9.4.x.
There are compilation issues, see comments.

@gregw gregw requested a review from sbordet February 18, 2021 13:06
@gregw gregw marked this pull request as ready for review February 18, 2021 13:06
Jetty 9.4.37 automation moved this from Review in progress to Reviewer approved Feb 18, 2021
@gregw gregw merged commit 324ab66 into jetty-9.4.x Feb 18, 2021
Jetty 9.4.37 automation moved this from Reviewer approved to Done Feb 18, 2021
@gregw gregw deleted the jetty-9.4.x-5979-nullable-gzip-etag branch February 20, 2021 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

Assignees
No one assigned
Labels
Sponsored This issue affects a user with a commercial support agreement
Projects
No open projects
Jetty 9.4.37
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@gregw @sbordet