Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5973 - Proxy client TLS authentication example. #5974

Merged
merged 1 commit into from Feb 17, 2021

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Feb 15, 2021

Examples, in form of test cases for a proxy that uses TLS client authentication
both towards the remote client and towards the server.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

@sbordet sbordet requested a review from gregw February 15, 2021 21:17
@sbordet sbordet added this to In progress in Jetty 9.4.37 via automation Feb 15, 2021
@sbordet sbordet linked an issue Feb 15, 2021 that may be closed by this pull request
Examples, in form of test cases for a proxy that uses TLS client authentication
both towards the remote client and towards the server.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet force-pushed the jetty-9.4.x-5973-proxy_client_tls_auth_example branch from f0d4ac0 to 25d9038 Compare February 17, 2021 13:49
Jetty 9.4.37 automation moved this from In progress to Review in progress Feb 17, 2021
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why are there 3 empty files in this PR? Can't the test just create them?

Request proxyRequest = super.newProxyRequest(request, rewrittenTarget);
proxyRequest.port(serverConnector.getLocalPort());
// Tag the request.
proxyRequest.tag(new AliasTLSTag(user));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I still don't really like dynamic tags..... but I have reconciled myself with them by think of tags like bag tags used for routing luggage and you can now get smart bag tags that response to RF queries... so I guess this is just a Smart Tag.

Jetty 9.4.37 automation moved this from Review in progress to Reviewer approved Feb 17, 2021
@sbordet sbordet merged commit 70d6724 into jetty-9.4.x Feb 17, 2021
Jetty 9.4.37 automation moved this from Reviewer approved to Done Feb 17, 2021
@sbordet sbordet deleted the jetty-9.4.x-5973-proxy_client_tls_auth_example branch February 17, 2021 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Proxy client TLS authentication example
2 participants