Jetty 10.0.x Fix #5605 Unblock non container Threads #5953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ensure that HttpInput is always closed to EOF, EarlyEOF or Error, so that non container threads doing blocking reads will not block forever, even if late. Delay recycling of HttpInput until next request is received.
Ensure that HttpInput is always closed to EOF, EarlyEOF or Error, so that non container threads doing blocking reads will not block forever, even if late. Delay recycling of HttpInput until next request is received.
test and fixes for the write side.
test and fixes for the write side.
Don't consumeAll before upgrade
reorder
fix test
cleanup debug
revert fillInterest cancellation and just abort connection instead. tested for all transports
Simplification. Always abort on any pending read or write in completion.
…05-wakeup-blocked-threads
Simplification. Always abort on any pending read or write in completion.
…threads' into jetty-10.0.x-5605-wakeup-blocked-threads
lorban
force-pushed
the
jetty-10.0.x-5605-wakeup-blocked-threads
branch
from
a992c03
to
ea51c8d
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
force-pushed
the
jetty-10.0.x-5605-wakeup-blocked-threads
branch
from
ea51c8d
to
d297e9c
Compare
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
lorban
changed the title
gregw
requested changes
Feb 9, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/HttpConnection.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
refactored the complete method to consider unrecoverable API states no matter what the httpout state actually is. This avoid duplication of OPEN, CLOSING, CLOSED etc. handling.
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…threads' into jetty-10.0.x-5605-wakeup-blocked-threads
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…the same ByteBuffer Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…emaphore Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…threads' into jetty-10.0.x-5605-wakeup-blocked-threads
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…GZIP is enabled Signed-off-by: Ludovic Orban <lorban@bitronix.be>
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
gregw
requested changes
Feb 15, 2021
jetty-server/src/main/java/org/eclipse/jetty/server/BlockingContentProducer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Ludovic Orban <lorban@bitronix.be>
…5605-wakeup-blocked-threads
gregw
reviewed
Feb 17, 2021
| /** | ||
| * A semaphore that assumes working under {@link AsyncContentProducer#lock()} scope. | ||
| */ | ||
| class LockedSemaphore |
There was a problem hiding this comment.
This looks like a useful class. Surprised it is not already available as a common extension of Condition.
gregw
approved these changes
Feb 17, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Candidate merge of #5936 into 10.0.x