Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5684 Fix testSetBadBoolean and remove @Disabled #5875

Merged
merged 1 commit into from Jan 12, 2021
Merged

Issue #5684 Fix testSetBadBoolean and remove @Disabled #5875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
5 changes: 3 additions & 2 deletions jetty-xml/src/test/java/org/eclipse/jetty/xml/XmlConfigurationTest.java
View file
Open in desktop
Expand Up @@ -1046,16 +1046,17 @@ public void testSetBooleanFalse() throws Exception
}

@Test
@Disabled
public void testSetBadBoolean() throws Exception
{
XmlConfiguration xmlConfiguration = asXmlConfiguration(
"<Configure class=\"org.eclipse.jetty.xml.XmlConfigurationTest$NativeHolder\">" +
" <Set name=\"boolean\">tru</Set>" +
"</Configure>");

//Any string other than "true" (case insensitive) will be false
//according to Boolean constructor.
NativeHolder bh = (NativeHolder)xmlConfiguration.configure();
assertTrue(bh.getBoolean(), "boolean['tru']");
assertFalse(bh.getBoolean(), "boolean['tru']");
}

@Test
Expand Down