Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5851 - remove WebSocketServletFactory as ServletContext attribute on destroy #5860

Merged
merged 1 commit into from Jan 20, 2021
Merged

Issue #5851 - remove WebSocketServletFactory as ServletContext attribute on destroy #5860

merged 1 commit into from Jan 20, 2021

Conversation

lachlan-roberts
Copy link
Contributor

Issue #5851

@lachlan-roberts
Issue #5851 - remove WebSocketServletFactory as ServletContext attrib…
f738493 
…ute on destroy

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
gregw approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lachlan-roberts lachlan-roberts merged commit 7598055 into jetty-9.4.x Jan 20, 2021
@lachlan-roberts lachlan-roberts deleted the jetty-9.4.x-5851-WebSocketServletCleanup branch January 20, 2021 04:50
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 9.4.37 via automation Jan 20, 2021
@lachlan-roberts lachlan-roberts moved this from In progress to Done in Jetty 9.4.37 Jan 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@janbartel janbartel Awaiting requested review from janbartel

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.37
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lachlan-roberts @gregw