New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5810 - Support bespoke PathSpec for servlets in embedded-jetty #5854
Issue #5810 - Support bespoke PathSpec for servlets in embedded-jetty #5854
Commits on Jan 5, 2021
-
Issue #5810 - Support bespoke PathSpec for servlets in embedded-jetty
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 725b858 - Browse repository at this point
Copy the full SHA 725b858View commit details
Commits on Jan 13, 2021
-
+ Created a common `Mapping` base for `FilterMapping` and `ServletMapping` + `Mapping` contains an array of PathSpec. The `String` based methods assume `ServletPathSpec`. + Convert most handling of string pathSpecs to `PathSpec` instances + Modified `ConstraintMapping` to also use a PathSpec + Modified JSP and annotation handling to cope with any existing non standard path specs + Made ServletHandler update mappings respect the order of the mappings TODO: + Should `ConstraintMapping` extend `Mapping` ? + Convert `ConstraintSecurityHandler` to use `PathMappings` so it can handle non standard PathSpecs + Review remaining calls to `Mapping.getPathSpecs` and `ConstrainMapping.getPathSpec` + Currently Quick Start operates on just the string versions of PathSpec, as it must be able to write a web.xml which can only contain standard path specs. Should it fail when it sees a non standard pathspec, or assume that it will again be programmatically added during quick start? + Review how frequently we are creating new arrays of path spec and/or converting path specs to/from strings. Best resolution for such things are ultility methods on Mapping (eg `#containsPathSpec`) + More tests
Configuration menu - View commit details
-
Copy full SHA for 77fe316 - Browse repository at this point
Copy the full SHA 77fe316View commit details -
+ Converted `ConstraintSecurityHandler` to use `PathMappings` so it can handle non standard PathSpecs
Configuration menu - View commit details
-
Copy full SHA for f4e4a10 - Browse repository at this point
Copy the full SHA f4e4a10View commit details -
Merge branch 'jetty-9.4.x' into jetty-9.4.x-5810-bespoke-pathspec-sup…
…port-alt Signed-off-by: gregw <gregw@webtide.com>
Configuration menu - View commit details
-
Copy full SHA for cba7b48 - Browse repository at this point
Copy the full SHA cba7b48View commit details -
+ Fixed test by reverting ServletMapping normalize
Configuration menu - View commit details
-
Copy full SHA for 30906f1 - Browse repository at this point
Copy the full SHA 30906f1View commit details -
Configuration menu - View commit details
-
Copy full SHA for eb66945 - Browse repository at this point
Copy the full SHA eb66945View commit details -
Configuration menu - View commit details
-
Copy full SHA for 8b1e81d - Browse repository at this point
Copy the full SHA 8b1e81dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1131348 - Browse repository at this point
Copy the full SHA 1131348View commit details -
Configuration menu - View commit details
-
Copy full SHA for b9bb370 - Browse repository at this point
Copy the full SHA b9bb370View commit details
Commits on Jan 15, 2021
-
Configuration menu - View commit details
-
Copy full SHA for e4a8132 - Browse repository at this point
Copy the full SHA e4a8132View commit details
Commits on Jan 16, 2021
-
Configuration menu - View commit details
-
Copy full SHA for 955fc58 - Browse repository at this point
Copy the full SHA 955fc58View commit details
Commits on Jan 19, 2021
-
Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-58…
…10-bespoke-pathspec-support-alt
Configuration menu - View commit details
-
Copy full SHA for 06bb7f2 - Browse repository at this point
Copy the full SHA 06bb7f2View commit details
Commits on Feb 19, 2021
-
Merge branch 'jetty-9.4.x' into jetty-9.4.x-5810-bespoke-pathspec-sup…
…port-alt Signed-off-by: gregw <gregw@webtide.com>
Configuration menu - View commit details
-
Copy full SHA for bcd9540 - Browse repository at this point
Copy the full SHA bcd9540View commit details -
Configuration menu - View commit details
-
Copy full SHA for e034132 - Browse repository at this point
Copy the full SHA e034132View commit details -
Configuration menu - View commit details
-
Copy full SHA for b93d0c3 - Browse repository at this point
Copy the full SHA b93d0c3View commit details