Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #5810 - Support bespoke PathSpec for servlets in embedded-jetty #5854

Closed

Commits on Jan 5, 2021

  1. Issue #5810 - Support bespoke PathSpec for servlets in embedded-jetty

    Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
    joakime committed Jan 5, 2021
    Configuration menu
    Copy the full SHA
    725b858 View commit details
    Browse the repository at this point in the history

Commits on Jan 13, 2021

  1. Refactor of fix for #5810

     + Created a common `Mapping` base for `FilterMapping` and `ServletMapping`
     + `Mapping` contains an array of PathSpec.  The `String` based methods assume `ServletPathSpec`.
     + Convert most handling of string pathSpecs to `PathSpec` instances
     + Modified `ConstraintMapping` to also use a PathSpec
     + Modified JSP and annotation handling to cope with any existing non standard path specs
     + Made ServletHandler update mappings respect the order of the mappings
    
     TODO:
     + Should `ConstraintMapping` extend `Mapping` ?
     + Convert `ConstraintSecurityHandler` to use `PathMappings` so it can handle non standard PathSpecs
     + Review remaining calls to `Mapping.getPathSpecs` and `ConstrainMapping.getPathSpec`
     + Currently Quick Start operates on just the string versions of PathSpec, as it must be able to write a web.xml which can only contain standard path specs.  Should it fail when it sees a non standard pathspec, or assume that it will again be programmatically added during quick start?
     + Review how frequently we are creating new arrays of path spec and/or converting path specs to/from strings.  Best resolution for such things are ultility methods on Mapping (eg `#containsPathSpec`)
     + More tests
    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    77fe316 View commit details
    Browse the repository at this point in the history
  2. Refactor of fix for #5810

     + Converted `ConstraintSecurityHandler` to use `PathMappings` so it can handle non standard PathSpecs
    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    f4e4a10 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'jetty-9.4.x' into jetty-9.4.x-5810-bespoke-pathspec-sup…

    …port-alt
    
    Signed-off-by: gregw <gregw@webtide.com>
    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    cba7b48 View commit details
    Browse the repository at this point in the history
  4. Refactor of fix for #5810

     + Fixed test by reverting ServletMapping normalize
    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    30906f1 View commit details
    Browse the repository at this point in the history
  5. Refactor of fix for #5810

     + More tests
    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    eb66945 View commit details
    Browse the repository at this point in the history
  6. Updated naming after review

    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    8b1e81d View commit details
    Browse the repository at this point in the history
  7. Updated after review

    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    1131348 View commit details
    Browse the repository at this point in the history
  8. Fixed quickstart

    gregw committed Jan 13, 2021
    Configuration menu
    Copy the full SHA
    b9bb370 View commit details
    Browse the repository at this point in the history

Commits on Jan 15, 2021

  1. work around CDI tests

    gregw committed Jan 15, 2021
    Configuration menu
    Copy the full SHA
    e4a8132 View commit details
    Browse the repository at this point in the history

Commits on Jan 16, 2021

  1. Configuration menu
    Copy the full SHA
    955fc58 View commit details
    Browse the repository at this point in the history

Commits on Jan 19, 2021

  1. Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-58…

    …10-bespoke-pathspec-support-alt
    gregw committed Jan 19, 2021
    Configuration menu
    Copy the full SHA
    06bb7f2 View commit details
    Browse the repository at this point in the history

Commits on Feb 19, 2021

  1. Merge branch 'jetty-9.4.x' into jetty-9.4.x-5810-bespoke-pathspec-sup…

    …port-alt
    
    Signed-off-by: gregw <gregw@webtide.com>
    gregw committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    bcd9540 View commit details
    Browse the repository at this point in the history
  2. Fixed test after merge

    gregw committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    e034132 View commit details
    Browse the repository at this point in the history
  3. updated file header

    Signed-off-by: gregw <gregw@webtide.com>
    gregw committed Feb 19, 2021
    Configuration menu
    Copy the full SHA
    b93d0c3 View commit details
    Browse the repository at this point in the history