Issue #5824 Durable ConstraintMappings. #5842
Conversation
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
…dler start Signed-off-by: Jan Bartel <janb@webtide.com>
There was a problem hiding this comment.
The PR introduces _durableMappings which is an alternative to constraintMappings when stopped, but a subset of _contrainMappings when started. I find this a little confusing and a bit different to our other durable collections which are always subsets.
I would prefer if the _constrainMappings was always updated and _durableMappings kept as a subset. Then on stop, it is just a matter of setting the _constrainMappings to be the same as the _durableMappings
| return _constraintMappings; | ||
| else | ||
| //otherwise, we only have durables | ||
| return _durableConstraintMappings; |
There was a problem hiding this comment.
Is this necessary? The _durableConstraintMappings is a subset of _constraintMappings, so isn't it always OK to return _constraintMappings?
There was a problem hiding this comment.
Oh I see.... will comment more in request for change....
Signed-off-by: Jan Bartel <janb@webtide.com>
Signed-off-by: Jan Bartel <janb@webtide.com>
closes #5824
Ensure that ConstraintMappings that are added to the ConstraintSecurityHandler before the context starts are retained across restarts, but those that are added after the context is starting (eg via annotations, web.xml/web-fragment.xml, javax.security api) are not.