Issue #5725 Review preventers. #5839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note that any Preventer that is documented as being fixed prior to jdk11 should be deleted from jetty-10/11 when this change is merged through. Signed-off-by: Jan Bartel <janb@webtide.com>
Closed
sbordet
approved these changes
Dec 23, 2020
|
@janbartel note that if you're going to remove these from Jetty 10, then |
|
@sbordet yes, my intention is to remove them in jetty-10, and yes I intend to change module-info.java appropriately. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5725
Reviewed the Preventers and deprecated them where there is information that the cause has been fixed in the jvm.
Note that any Preventer that is documented as being fixed prior to jdk11 should be deleted from jetty-10/11 when this change is merged through.