Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add websocket operations-guide to Jetty 10 #5806

Merged
merged 4 commits into from Dec 30, 2020
Merged

Add websocket operations-guide to Jetty 10 #5806

merged 4 commits into from Dec 30, 2020

Conversation

lachlan-roberts
Copy link
Contributor

@lachlan-roberts lachlan-roberts commented Dec 14, 2020 •
edited

Issue #5229

@lachlan-roberts
Issue #5229 - add websocket docs for operations guide
89e3920 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Some changes to the websocket operations-guide.
4cd335c 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts
Merge remote-tracking branch 'origin/jetty-10.0.x' into jetty-10.0.x-…
a3af965 
…5229-WebSocketDocumentation

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
@lachlan-roberts lachlan-roberts added this to In progress in Jetty 10.0.1 via automation Dec 14, 2020
sbordet
sbordet requested changes Dec 14, 2020
View reviewed changes
Copy link
Contributor

@sbordet sbordet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a command line example of enabling websocket.
Assume you don't know anything about Jetty and WebSocket, you want to have a command line to copy and paste, and check the results.

jetty-documentation/src/main/asciidoc/operations-guide/websocket/chapter.adoc Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/operations-guide/websocket/chapter.adoc Outdated Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/operations-guide/websocket/chapter.adoc Outdated Show resolved Hide resolved
jetty-documentation/src/main/asciidoc/operations-guide/websocket/chapter.adoc Outdated Show resolved Hide resolved
Jetty 10.0.1 automation moved this from In progress to Review in progress Dec 14, 2020
@lachlan-roberts
Changes from review.
b5884f4 
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Jetty 10.0.1 automation moved this from Review in progress to Reviewer approved Dec 30, 2020
@sbordet sbordet merged commit e341f4c into jetty-10.0.x Dec 30, 2020
Jetty 10.0.1 automation moved this from Reviewer approved to Done Dec 30, 2020
@sbordet sbordet deleted the jetty-10.0.x-5229-WebSocketDocumentation branch December 30, 2020 19:17
@lachlan-roberts lachlan-roberts mentioned this pull request Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbordet sbordet sbordet approved these changes

@WalkerWatch WalkerWatch Awaiting requested review from WalkerWatch

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 10.0.1
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lachlan-roberts @sbordet