Issue #5713 Remove dependency on derby #5728
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan Bartel <janb@webtide.com>
joakime
reviewed
Nov 25, 2020
| @@ -68,7 +68,7 @@ | |||
| <settingsPath>src/it/settings.xml</settingsPath> | |||
| <surefire.rerunFailingTestsCount>0</surefire.rerunFailingTestsCount> | |||
| <testcontainers.version>1.15.0</testcontainers.version> | |||
| <derby.version>10.14.2.0</derby.version> | |||
| <maria.version>2.7.0</maria.version> | |||
There was a problem hiding this comment.
So we switched from derby to maria?
Still the same dependency count?
There was a problem hiding this comment.
No, we have 1 less dependency, I removed Derby. We already had mariadb.
There was a problem hiding this comment.
@janbartel not sure we have any dependency on mariadb (except docker test for jdbc session test) and this can be removed
There was a problem hiding this comment.
The maria DB used in org.eclipse.jetty.tests:test-jdbc-sessions in jetty-9.4.x is referencing (already) ...
[INFO] +- org.testcontainers:mariadb:jar:1.15.0:test
[INFO] +- org.mariadb.jdbc:mariadb-java-client:jar:2.7.0:test
That's a tiny set of deps.
We should probably use these new properties in test-jdbc-sessions too.
There was a problem hiding this comment.
yup I agree on using the property or removing it.
Signed-off-by: olivier lamy <oliver.lamy@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #5713
jetty-plus does not need the dependency on derby so I removed it. That left the test/test-loginservice with a dependency on derby, so I've changed that to use the same docker-style test that the tests/test-sessions/test-jdbc-sessions use, so at least we have a single set of common dependencies (uses maria db for the database). Also cleaned up the test code.