Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #5633 - Allow to configure HttpClient request authority. #5640

Merged
merged 1 commit into from Nov 16, 2020
Merged

Fixes #5633 - Allow to configure HttpClient request authority. #5640

merged 1 commit into from Nov 16, 2020
+73 −13

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Nov 11, 2020

Introduced HttpDestination.send(Request, Response.CompleteListener) to send a request using the given destination.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

@sbordet
Fixes #5633 - Allow to configure HttpClient request authority.
a308881 
Introduced HttpDestination.send(Request, Response.CompleteListener) to send a request using the given destination.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet requested a review from gregw November 11, 2020 16:13
@sbordet sbordet linked an issue Nov 11, 2020 that may be closed by this pull request
Allow to configure HttpClient request authority #5633
Closed
@sbordet sbordet added this to In progress in Jetty 9.4.35 via automation Nov 11, 2020
@sbordet sbordet requested a review from joakime November 11, 2020 16:14
gregw
gregw approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lots of methods called send.... hard to follow.... but the unit test is good, so ultimately LGTM

Jetty 9.4.35 automation moved this from In progress to Reviewer approved Nov 16, 2020
joakime
joakime approved these changes Nov 16, 2020
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbordet sbordet merged commit 3cbd117 into jetty-9.4.x Nov 16, 2020
Jetty 9.4.35 automation moved this from Reviewer approved to Done Nov 16, 2020
@sbordet sbordet deleted the jetty-9.4.x-5633-httpclient_configure_authority branch November 16, 2020 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

@joakime joakime joakime approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.35
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow to configure HttpClient request authority
3 participants
@sbordet @gregw @joakime