Add Connection:close if content can't be consumed during a sendError. Processed after the request has returned to the container.

Signed-off-by: Greg Wilkins <gregw@webtide.com>

…05-unconsumed-send-error

 + Add close on all uncommitted requests when content cannot be consumed.

 + fixed comment
 + space comma

…e or similar)

I do not think it was valid to always consumeAll in COMPLETE as this could break upgrades with both 101s and 200s
Instead I have reverted to having this consumeAll logic only:
 + in sendError once control has passed back to the container and we are about to generate an error page.
 + in front of all the sendRedirection that we do without calling the application first.

Extra tests also added

reverted test

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>

…05-unconsumed-send-error

Fixed test

+ added redirect methods that consumeAll
+ ensureContentConsumedOrConnectionClose renamed to ensureConsumeAllOrNotPersistent
+ ensureConsumeAllOrNotPersistent now handles HTTP/1.0 and HTTP/1.1 differently

 + better javadoc
 + filter out keep-alive
 + added more tests

 + better javadoc

 + fixed form redirection test for http 1.0 and 1.1

 + HttpGenerator removes keep-alive if close present
 + Use isRedirection

…-9.4.x-5605-unconsumed-send-error