New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue #5539 - Proper StatisticsServlet output format via content negotiation #5560
Merged
joakime
merged 10 commits into
jetty-9.4.x
from
jetty-9.4.x-5539-statisticsservlet-output
Nov 17, 2020
Merged
Issue #5539 - Proper StatisticsServlet output format via content negotiation #5560
joakime
merged 10 commits into
jetty-9.4.x
from
jetty-9.4.x-5539-statisticsservlet-output
Nov 17, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
commented
Nov 2, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
Outdated
Show resolved
Hide resolved
gregw
requested changes
Nov 2, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
Outdated
Show resolved
Hide resolved
joakime
force-pushed
the
jetty-9.4.x-5539-statisticsservlet-output
branch
from
November 2, 2020 17:01
178924b
to
b02c6b1
Compare
joakime
commented
Nov 2, 2020
jetty-webapp/src/test/java/org/eclipse/jetty/webapp/WebInfConfigurationTest.java
Show resolved
Hide resolved
joakime
added
the
Sponsored
This issue affects a user with a commercial support agreement
label
Nov 16, 2020
gregw
requested changes
Nov 16, 2020
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
Outdated
Show resolved
Hide resolved
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/StatisticsServlet.java
Outdated
Show resolved
Hide resolved
…tiation Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
+ It was matching on jetty-util-ajax-#.jar as well. Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
joakime
force-pushed
the
jetty-9.4.x-5539-statisticsservlet-output
branch
from
November 16, 2020 15:10
4d415d6
to
683d9a9
Compare
I need to add test cases to test-distribution for this. |
+ Updating module definition for JSON Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
gregw
approved these changes
Nov 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Bug
For general bugs on Jetty side
Enhancement
Sponsored
This issue affects a user with a commercial support agreement
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StatisticsServer can now present it's information in (text, html, json, and xml).
Selected via normal HTTP content negotiation.
Example output (expand to see details)
$ curl -H "Accept: text/xml" http://localhost:9090/stats
$ curl -H "Accept: application/json" http://localhost:9090/stats | json_pp
$ curl -H "Accept: text/plain" http://localhost:9090/stats
$ curl -H "Accept: text/html" http://localhost:9090/stats
Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com