Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backdown default version of asm to 7. #5478

Closed

Conversation

janbartel
Copy link
Contributor

Backing down the default version of asm from 9 to 7. This default version value is only used in the case where we cannot determine the actual version of the asm jars at runtime.

Signed-off-by: Jan Bartel <janb@webtide.com>
@janbartel janbartel requested a review from gregw October 19, 2020 22:08
@janbartel janbartel added this to In progress in Jetty 9.4.33 via automation Oct 19, 2020
Jetty 9.4.33 automation moved this from In progress to Reviewer approved Oct 19, 2020
Jetty 9.4.33 automation moved this from Reviewer approved to Review in progress Oct 20, 2020
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually I think we should just pass 7 as the version of the API we have extended.
I'm not sure why we are doing the dynamics anyway? @sbordet Do you recall why we wrote this manifest inspection code?

@gregw
Copy link
Contributor

gregw commented Oct 20, 2020

@olamy Were the CI failures on this spurious?

@janbartel
Copy link
Contributor Author

@sbordet do you know about changes to the proxy stuff that would have caused this CI failure?

@olamy
Copy link
Member

olamy commented Oct 20, 2020

sadly spurious... next run should be ok. This test sometimes fail where there is plenty of build in parallel

@gregw
Copy link
Contributor

gregw commented Oct 20, 2020

Replaced by #5479

@gregw gregw closed this Oct 20, 2020
Jetty 9.4.33 automation moved this from Review in progress to Done Oct 20, 2020
@joakime joakime deleted the jetty-9.4.x-backdown-default-asm-version branch October 22, 2020 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Jetty 9.4.33
  
Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants