Fixes #5378 Setting Holders during STARTING #5397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Holders are now started/initialized if needed by a new utility method
|
I thought this issue was unique to Jetty 10? |
|
@joakime The underlying problem (not being able to add a holder during STARTING) is in 9.4. It only manifested in 10.beta2 because WS changed to add a filter during STARTING. |
|
The specific change is from PR #5115, where we now lazily create the |
janbartel
requested changes
Oct 6, 2020
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/ServletContextHandlerTest.java
Outdated
Show resolved
Hide resolved
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/ServletContextHandlerTest.java
Outdated
Show resolved
Hide resolved
jetty-servlet/src/main/java/org/eclipse/jetty/servlet/ServletHandler.java
Show resolved
Hide resolved
jetty-servlet/src/test/java/org/eclipse/jetty/servlet/ServletContextHandlerTest.java
Outdated
Show resolved
Hide resolved
Holders are now started/initialized if needed by a new utility method
janbartel
approved these changes
Oct 7, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5378 Holders are now started/initialized if needed by a new utility method