Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400. #5234

Merged
merged 2 commits into from
Sep 9, 2020
Merged

Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400. #5234

merged 2 commits into from
Sep 9, 2020

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Sep 4, 2020

Signed-off-by: Joakim Erdfelt joakim.erdfelt@gmail.com

@joakime
Issue #5233 - Bad/Unsupported HTTP version should return 505 not 400.
b2e0f69 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime added the Bug For general bugs on Jetty side label Sep 4, 2020
@joakime joakime self-assigned this Sep 4, 2020
@joakime joakime added this to In progress in Jetty 9.4.32 via automation Sep 4, 2020
@joakime joakime moved this from In progress to Review in progress in Jetty 9.4.32 Sep 4, 2020
@joakime joakime linked an issue Sep 4, 2020 that may be closed by this pull request
Bad/Unsupported HTTP version should return 505 not 400 #5233
Closed
gregw
gregw requested changes Sep 7, 2020
View reviewed changes
Copy link
Contributor

@gregw gregw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix some more tests.
I'm a bit cautious about doing this in 9... but should be OK. Will probably alarm some users that count 500s and 400s on very large deployments.

@joakime
Issue #5233 - correcting NCSARequestLogTest expectation on unsupporte…
56b1d17 
…d version

Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@joakime joakime requested a review from gregw September 8, 2020 14:29
Jetty 9.4.32 automation moved this from Review in progress to Reviewer approved Sep 8, 2020
@joakime joakime merged commit e7d15af into jetty-9.4.x Sep 9, 2020
Jetty 9.4.32 automation moved this from Reviewer approved to Done Sep 9, 2020
@joakime joakime deleted the jetty-9.4.x-http-09-response-505 branch September 9, 2020 14:23
@joakime joakime mentioned this pull request Sep 9, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gregw gregw gregw approved these changes

Assignees

@joakime joakime

Labels
Bug For general bugs on Jetty side
Projects
No open projects
Jetty 9.4.32
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bad/Unsupported HTTP version should return 505 not 400
2 participants
@joakime @gregw