Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5103 - Proxy sets protocol version to 2.0 instead of 1.1 when … #5225

Merged
merged 1 commit into from Sep 2, 2020

Conversation

sbordet
Copy link
Contributor

@sbordet sbordet commented Sep 2, 2020

…accessed from H2 client.

Fixed by removing the explicit version copy.
Leaving it at default would make the client transport
decide the version based on the transport protocol it uses.

Signed-off-by: Simone Bordet simone.bordet@gmail.com

…accessed from H2 client.

Fixed by removing the explicit version copy.
Leaving it at default would make the client transport
decide the version based on the transport protocol it uses.

Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
@sbordet sbordet added this to In progress in Jetty 9.4.32 via automation Sep 2, 2020
@sbordet sbordet requested a review from joakime September 2, 2020 14:46
Jetty 9.4.32 automation moved this from In progress to Reviewer approved Sep 2, 2020
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sbordet sbordet merged commit e940e5c into jetty-9.4.x Sep 2, 2020
Jetty 9.4.32 automation moved this from Reviewer approved to Done Sep 2, 2020
@sbordet sbordet deleted the jetty-9.4.x-5103_proxy_wrong_http_version branch September 2, 2020 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Jetty 9.4.32
  
Done
Development

Successfully merging this pull request may close these issues.

Proxy sets protocol version to 2.0 instead of 1.1 when accessed from H2 client
2 participants