Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #5105 - StatisticsHandler Graceful Shutdown of Async Requests #5175

Merged
merged 8 commits into from Aug 28, 2020
Merged

Issue #5105 - StatisticsHandler Graceful Shutdown of Async Requests #5175

merged 8 commits into from Aug 28, 2020

Commits on Aug 19, 2020

  1. Also manage graceful shutdown of already started async requests 

    Signed-off-by: Thomas Draebing <thomas.draebing@sap.com>
    @thomasdraebing
    thomasdraebing committed Aug 19, 2020
    Copy the full SHA
    a46ed5b View commit details
    Browse the repository at this point in the history

  2. Issue #5105 - fix StatisticsHandler bug with async dispatched requests 

    If the request is async dispatched, the check state.isSuspended() is not
correct to determine if the request was async or not. The check
state.isAsyncStarted() should be used instead.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 19, 2020
    Copy the full SHA
    32358b1 View commit details
    Browse the repository at this point in the history

  3. Issue #5105 - add optional configuration to not wait for suspended re… 

    …quests in StatisticsHandler

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 19, 2020
    Copy the full SHA
    a65f001 View commit details
    Browse the repository at this point in the history

  4. Issue #5105 - fix GracefulStopTest expectations from 503s to 404s 

    StatisticsHandler no longer gives 503 responses after shutdown.

Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 19, 2020
    Copy the full SHA
    0fae221 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2020

  1. change name of waitForSuspendedRequestsOnShutdown to asyncGraceful 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 24, 2020
    Copy the full SHA
    c0268c5 View commit details
    Browse the repository at this point in the history

Commits on Aug 25, 2020

  1. StatisticsHandler should still return 503 responses on shutdown 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 25, 2020
    Copy the full SHA
    2d5da1f View commit details
    Browse the repository at this point in the history

  2. DebugHandler should use isAsyncStarted() instead of isSuspended() 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 25, 2020
    Copy the full SHA
    8edb768 View commit details
    Browse the repository at this point in the history

Commits on Aug 26, 2020

  1. Issue #5105 - change asyncGraceful to gracefulShutdownWaitsForRequests 

    Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
    @lachlan-roberts
    lachlan-roberts committed Aug 26, 2020
    Copy the full SHA
    a9c90d3 View commit details
    Browse the repository at this point in the history