Add GracefulShutdownHandler #5156
Conversation
|
Thank you for the pull request. But we need to satisfy the requirements of Eclipse Legal in order to accept / merge this pull request. The Eclipse Foundation ECA validation has failed for the commits on this pull request. See the "Details" link on the |
This adds a handler that takes care of keeping the connection alive during a shutdown until the request is finished or the graceful stop timeout is reached. This is similar to what the StatisticsHandler already does, but does not collect the metrics, thereby reducing resource usage. Also the StatisticsHandler does not wait for requests in dispatched state. Signed-off-by: Thomas Draebing <thomas.draebing@sap.com>
thomasdraebing
force-pushed
the
graceful-handler
branch
from
902f3d8
to
bdecde3
Compare
|
I'm against a separate GracefulShutdownHandler as keep global counts is expensive in terms of contended memory/locks etc. It would be bad to do that twice if you wish to have stats and graceful shutdown. |
|
Hmmmm maybe we could have one that doesn't do stats, but the behaviour should be the same as for the stats one and they should be mutually exclusive (at the module level) so we don't get both. We need to work out what the problem is with the stats handler rather than just avoiding the issue. |
|
See more comments in #5105 that discuss a potential way forward. |
|
An easier fix for #5105 was found. Thus, there should be no need to add an additional handler. |
Work in progress
This pull requests tries to resolve Issue #5105.
This adds a handler that takes care of keeping the connection alive
during a shutdown until the request is finished or the graceful stop
timeout is reached.
This is similar to what the StatisticsHandler already does, but does
not collect the metrics, thereby reducing resource usage. Also the
StatisticsHandler does not wait for requests in dispatched state.
TODOs: