Issue #5150 - Infinite connection timeout support in ManagedSelector #5151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for the pull request. But we need to satisfy the requirements of Eclipse Legal in order to accept / merge this pull request. The Eclipse Foundation ECA validation has failed for the commits on this pull request. See the "Details" link on the |
olegmoz
force-pushed
the
5150-zero-connection-timeout
branch
from
df72e4b
to
e4813e4
Compare
Signed-off-by: Oleg Mozzhechkov <oleg.mozzhechkov@gmail.com>
olegmoz
force-pushed
the
5150-zero-connection-timeout
branch
from
e4813e4
to
bffd6a2
Compare
|
@joakime thanks, I have signed-off the commit |
joakime
changed the title
sbordet
requested changes
Aug 13, 2020
| @@ -888,7 +888,11 @@ public String toString() | |||
| { | |||
| this.channel = channel; | |||
| this.attachment = attachment; | |||
| this.timeout = ManagedSelector.this._selectorManager.getScheduler().schedule(this, ManagedSelector.this._selectorManager.getConnectTimeout(), TimeUnit.MILLISECONDS); | |||
| final long timeout = ManagedSelector.this._selectorManager.getConnectTimeout(); | |||
There was a problem hiding this comment.
Please remove final, not necessary.
Signed-off-by: Oleg Mozzhechkov <oleg.mozzhechkov@gmail.com>
|
@sbordet thanks, removed |
sbordet
approved these changes
Aug 14, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5150
ManagedSelectornever timeouts connection in case connection timeout is set to zero.