Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #5079 - :authority header for IPv6 address not having square br… #5128

Merged
merged 5 commits into from Aug 11, 2020

Commits on Aug 7, 2020

  1. Fixes #5079 - :authority header for IPv6 address not having square br…

    …ackets.
    
    On the client:
    * Origin.Address.host is passed through HostPort.normalizeHost(),
    so that if it is IPv6 is bracketed.
    Now the ipv6 address passed to an `HttClient` request is bracketed.
    * HttpRequest was de-bracketing the host, but now it does not anymore.
    
    On the server:
    * Request.getLocalAddr(), getLocalName(), getRemoteAddr(),
    getRemoteHost(), getServerName(), when dealing with an IPv6 address,
    return it bracketed.
    The reason to return bracketed IPv6 also from *Addr() methods is that
    if it is used with InetAddress/InetSocketAddress it still works, but
    often it is interpreted as a URI host so brackets are necessary.
    * DoSFilter was blindly bracketing - now it does not.
    
    Added a number of test cases, and fixed those that expected
    non-bracketed IPv6.
    
    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    sbordet committed Aug 7, 2020
    Configuration menu
    Copy the full SHA
    d53d9d8 View commit details
    Browse the repository at this point in the history

Commits on Aug 8, 2020

  1. Configuration menu
    Copy the full SHA
    dd4c1db View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2020

  1. Fixes #5079 - :authority header for IPv6 address not having square br…

    …ackets.
    
    Fixed Jenkins failures by disabling tests that require IPv6 if it is not available.
    
    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    sbordet committed Aug 10, 2020
    Configuration menu
    Copy the full SHA
    867621a View commit details
    Browse the repository at this point in the history

Commits on Aug 11, 2020

  1. Fixes #5079 - :authority header for IPv6 address not having square br…

    …ackets.
    
    Updates after review.
    
    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    sbordet committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    897e766 View commit details
    Browse the repository at this point in the history
  2. Fixes #5079 - :authority header for IPv6 address not having square br…

    …ackets.
    
    Reverted code changes to HttpClient.normalizeHost().
    
    Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
    sbordet committed Aug 11, 2020
    Configuration menu
    Copy the full SHA
    2e73f80 View commit details
    Browse the repository at this point in the history