Issue #5122 - Improve connection statistics for WebSocket #5125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ctionStatistics Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
…n SessionTracker Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Aug 11, 2020
...mon/src/main/java/org/eclipse/jetty/websocket/common/util/WebSocketConnectionStatistics.java
Outdated
Show resolved
Hide resolved
…cludeConnectionStatistics Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Aug 17, 2020
jetty-io/src/main/java/org/eclipse/jetty/io/IncludeExcludeConnectionStatistics.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/IncludeExcludeConnectionStatistics.java
Outdated
Show resolved
Hide resolved
jetty-io/src/main/java/org/eclipse/jetty/io/IncludeExcludeConnectionStatistics.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
approved these changes
Aug 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #5122
Add a
WebSocketConnectionStatisticsclass which can be used to record only stats about WebSocket connections and not include stats from HTTP connections such as the upgrade requests.Also put a managedAttribute on the
SessionTrackerto get information about the number of active WebSocket Sessions which works without having to configure theConnectorstatistics mechanism.