Issue #4824 - add configuration on RemoteEndpoint for maxOutgoingFrames #5059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
|
Maybe it would be better if instead we monitor how many frames are queued at a lower level and if this is exceeded we simply just fail the entire connection. |
|
@lachlan-roberts i think this PR needs a refresh / merge from |
…24-WSmaxOutgoingFrames
sbordet
requested changes
Sep 2, 2020
| callback = from(callback, numOutgoingFrames::decrementAndGet); | ||
| if (outgoingFrames > maxNumOutgoingFrames) | ||
| { | ||
| callback.writeFailed(new IOException("Exceeded max outgoing frames: " + outgoingFrames + ">" + maxNumOutgoingFrames)); |
There was a problem hiding this comment.
Please change the exception from IOException to WritePendingException.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Sep 4, 2020
jetty-websocket/websocket-api/src/main/java/org/eclipse/jetty/websocket/api/RemoteEndpoint.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
sbordet
approved these changes
Sep 7, 2020
…24-WSmaxOutgoingFrames
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Attempt to address issue #4824 at the Jetty WebSocket API level.
If there are more than
maxOutgoingFrameswaiting to send, any additional sends will fail immediately instead of continuing to queue up in the flusher. The callback will be failed immediately but it will not fail the entire ws connection.This method is called
maxOutgoingFramesbut its not really as the implementation could later on decide to fragment each send from theWebSocketRemoteEndpointinto multiple frames.