#1503: if STRIP_IPV6 is set, do not add the brackets if they are not … #4897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You need to comply with the Eclipse requirements (sign the ECA). I fear that this change may have undesired effects on URL construction, where the brackets are needed. We would also need a test case. |
|
@gueuselambix due to Eclipse Foundation policy, we can only accept PRs for contributors who have signed the Eclipse ECA - click on 'Details' in the failed check above for more information. Furthermore, please consider comments by @sbordet regarding the substance of this PR. |
|
This has been superseded by the work done for #5079. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…present yet