Issue #4888 - Request getSession() now returns existing cached session if found #4889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ession if found Instead of logging and exception and returning null, if an existing Session is found in the session cache when attempting to add a new session then the existing session is used instead and returned Signed-off-by: Christopher L. Shannon <christopher.l.shannon@gmail.com>
|
Since @janbartel marked this as "do not merge" , i've downgraded this from a formal PR to a draft PR until her questions are answered. |
|
Note: we are close to having a 9.4.31 release (next week or two), so if you want to see this change in 9.4.31, I would advise you to resolve the unresolved questions that @janbartel has. |
gregw
requested changes
Sep 1, 2020
|
@janbartel - Thanks a lot, I will give it a shot but I think you are right that this will fix the issue. I have been running a custom build for a while now to fix it for myself but I'm glad that some others were able to report back a test case to demonstrate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of logging and exception and returning null, if an existing
Session is found in the session cache when attempting to add a new
session then the existing session is used instead and returned