Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4550 XmlConfiguration argument matching #4599

Merged
merged 7 commits into from
Feb 25, 2020
Merged

Issue #4550 XmlConfiguration argument matching #4599

merged 7 commits into from
Feb 25, 2020

Commits on Feb 22, 2020

  1. Issue #4550 XmlConfiguration argument matching 

    Improve argument matching by:
 + rejecting obviously non matches (with allowance for unboxing)
 + sorting methods so that derived arguments are tried before more generic (eg String before Object)

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    2073003 View commit details
    Browse the repository at this point in the history

  2. Issue #4550 XmlConfiguration argument matching 

    Improve argument matching by:
 + can unbox from any Number to any Number

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 22, 2020
    Configuration menu
    Copy the full SHA
    f35522c View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2020

  1. Issue #4550 

    Do not check the assignability of the arguments.  Instead rely on the order of the methods.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    d6843a9 View commit details
    Browse the repository at this point in the history

  2. Issue #4550 

    unbox test no longer required

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    3728314 View commit details
    Browse the repository at this point in the history

  3. Issue #4550 

    Simplified test

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    626fe71 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2020

  1. Issue #4550 

    Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    39dd245 View commit details
    Browse the repository at this point in the history

  2. Issue #4550 

    Cleanup comparator

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Feb 25, 2020
    Configuration menu
    Copy the full SHA
    a95e40e View commit details
    Browse the repository at this point in the history