Issue #4383 - synchronize multiparts for cleanup from different thread #4498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
requested changes
Jan 20, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Outdated
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Show resolved
Hide resolved
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
reviewed
Jan 21, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
janbartel
reviewed
Jan 23, 2020
jetty-server/src/main/java/org/eclipse/jetty/server/MultiPartFormInputStream.java
Outdated
Show resolved
Hide resolved
janbartel
approved these changes
Jan 23, 2020
lachlan-roberts
force-pushed
the
jetty-10.0.x-4383-MultiPartNPE
branch
from
c4a3855
to
9b9cc15
Compare
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
force-pushed
the
jetty-10.0.x-4383-MultiPartNPE
branch
from
9b9cc15
to
f76687a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Lachlan Roberts lachlan@webtide.com
Issue #4383
Changes from #4388 for jetty-10.0.x after we decided to merge only the minimal NPE fix to jetty-9.4.x and bring the rest of the changes to 10.
This fixes issues caused when the parsing is done in a different thread to the part cleanup.