Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jetty 9.4.x 4331 async close complete3 #4409

Merged
merged 41 commits into from Dec 19, 2019
Merged

Jetty 9.4.x 4331 async close complete3 #4409

merged 41 commits into from Dec 19, 2019

Commits on Dec 2, 2019

  1. Issue #4376 Async Content Complete 

    Added test harness to reproduce unready completing write.
Fixed test by not closing output prior to becoming READY

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 2, 2019
    Copy the full SHA
    ec969f4 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Async Write Complete 

    Test harness to reproduce unready when closing/completing.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 2, 2019
    Copy the full SHA
    4592441 View commit details
    Browse the repository at this point in the history

  3. Issue #4331 Async Write Complete 

    test both PENDING and UNREADY

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 2, 2019
    Copy the full SHA
    be28e87 View commit details
    Browse the repository at this point in the history

Commits on Dec 3, 2019

  1. Issue #4331 Async Write Complete 

    test cleanups

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 3, 2019
    Copy the full SHA
    d686f58 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Async Close Complete 

    Cleanups of write

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 3, 2019
    Copy the full SHA
    41daa3f View commit details
    Browse the repository at this point in the history

  3. Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-43… 

    …31-asyncCloseComplete2
    @gregw
    gregw committed Dec 3, 2019
    Copy the full SHA
    49fd2ed View commit details
    Browse the repository at this point in the history

Commits on Dec 4, 2019

  1. WIP 

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 4, 2019
    Copy the full SHA
    85eaa1f View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Work in progress

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 4, 2019
    Copy the full SHA
    a699aa0 View commit details
    Browse the repository at this point in the history

Commits on Dec 5, 2019

  1. Issue #4331 Close Complete 

    Added async close to HttpWriter and ResponseWriter
Always use async close, with blocker if necessary.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 5, 2019
    Copy the full SHA
    186164c View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Working async close complete!

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 5, 2019
    Copy the full SHA
    88398c8 View commit details
    Browse the repository at this point in the history

  3. Issue #4331 Close Complete 

    invert test as we can now call complete when not ready!

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 5, 2019
    Copy the full SHA
    cfc63a9 View commit details
    Browse the repository at this point in the history

  4. Issue #4331 Close Complete 

    fixed transition to ERROR state

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 5, 2019
    Copy the full SHA
    40ebd16 View commit details
    Browse the repository at this point in the history

  5. Issue #4331 Close Complete 

    async close after onError

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 5, 2019
    Copy the full SHA
    b5971a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 6, 2019

  1. Issue #4331 Close Complete 

    minor cleanups

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 6, 2019
    Copy the full SHA
    d53194b View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Fix for proxy tests

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 6, 2019
    Copy the full SHA
    8340a20 View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2019

  1. Issue #4331 Close Complete 

    Fix write loop to handle clear of p=0,l=0 rather than p=l

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 8, 2019
    Copy the full SHA
    ca0e0c4 View commit details
    Browse the repository at this point in the history

Commits on Dec 9, 2019

  1. Issue #4331 Close Complete 

    Removed old close on all content mechanism
Cleanups and some more TODOs

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 9, 2019
    Copy the full SHA
    1da0062 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2019

  1. Issue #4331 Close Complete 

    a reworking of HttpOutput to separate out API state.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 10, 2019
    Copy the full SHA
    7612bb5 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Soft close for Dispatcher
release buffer in onWriteComplete

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 10, 2019
    Copy the full SHA
    589b71a View commit details
    Browse the repository at this point in the history

  3. Issue #4331 Close Complete 

    Set _onError in onWriteComplete
NOOP callback instead of null

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 10, 2019
    Copy the full SHA
    8553f41 View commit details
    Browse the repository at this point in the history

  4. Issue #4331 Close Complete 

    failure closes HttpOutput

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 10, 2019
    Copy the full SHA
    6478e57 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2019

  1. Issue #4331 Close Complete 

    Moved closedCallback handling to onWriteComplete

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 11, 2019
    Copy the full SHA
    7719bec View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Additional test of complete during blocking write.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 11, 2019
    Copy the full SHA
    6caa9b9 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2019

  1. Issue #4331 Close Complete 

    reimplemented blocking close to sometimes be async

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 12, 2019
    Copy the full SHA
    32dbf97 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    ascii "art"

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 12, 2019
    Copy the full SHA
    5774a73 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2019

  1. Issue #4331 Close Complete 

    Code cleanup.  Use a CLOSE state rather than non null closedCallback to be clearer that it is a state.
Renamed close(Callback) to complete(Callback)
Renamed and simplified closed() to completed()

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 13, 2019
    Copy the full SHA
    a6723a2 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Do not dispatch
Better ascii art
improved close impl to be similar to complete

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 13, 2019
    Copy the full SHA
    1f76c52 View commit details
    Browse the repository at this point in the history

  3. Issue #4331 Close Complete 

    More test cases

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 13, 2019
    Copy the full SHA
    210f9ff View commit details
    Browse the repository at this point in the history

  4. Issue #4331 Close Complete 

    retain execute behaviour in 9.4. review in 10.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 13, 2019
    Copy the full SHA
    f86a27e View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2019

  1. Improved javadoc and ascii art

    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    2ce71ba View commit details
    Browse the repository at this point in the history

  2. Improved CLOSING 

    Switch to CLOSING state as soon as last write is done, even if several non last channelWrites will be done.   This allows a subsequent call to close to know that nothing needs to be written and can avoid some EOF exceptions. Now onWriteComplete acts only on the passed in last parameter.

Added test for sendContent
    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    a3500e1 View commit details
    Browse the repository at this point in the history

  3. WIP 

    Aggregate within lock
pipeline test debug
    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    54f0bb0 View commit details
    Browse the repository at this point in the history

  4. Avoid creating ignored exception when Idle or Failed.

    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    753df7f View commit details
    Browse the repository at this point in the history

  5. Try a parse without fill to avoid unconsumed input debug

    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    534aa76 View commit details
    Browse the repository at this point in the history

  6. fixed pipeline size

    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    95811d7 View commit details
    Browse the repository at this point in the history

  7. release buffer before callback

    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    44c82b7 View commit details
    Browse the repository at this point in the history

  8. turn off debug 

    Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 16, 2019
    Copy the full SHA
    d623c00 View commit details
    Browse the repository at this point in the history

Commits on Dec 17, 2019

  1. Issue #4331 Close Complete 

    Better javadoc
refactored onWriteComplete logic to be simpler
fixed bug with flush of last written byte

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 17, 2019
    Copy the full SHA
    88fff66 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Completely reworked test harness for better coverage.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 17, 2019
    Copy the full SHA
    f407df3 View commit details
    Browse the repository at this point in the history

Commits on Dec 18, 2019

  1. Merge remote-tracking branch 'origin/jetty-9.4.x' into jetty-9.4.x-43… 

    …31-asyncCloseComplete3
    @gregw
    gregw committed Dec 18, 2019
    Copy the full SHA
    6872c33 View commit details
    Browse the repository at this point in the history

  2. Issue #4331 Close Complete 

    Reworked order of ifs to match logic above in onWriteComplete

Signed-off-by: Greg Wilkins <gregw@webtide.com>
    @gregw
    gregw committed Dec 18, 2019
    Copy the full SHA
    b7014a7 View commit details
    Browse the repository at this point in the history