Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue #4156 - Session Already in Cache during forwarding #4159

Merged
merged 2 commits into from
Oct 14, 2019
Merged

Issue #4156 - Session Already in Cache during forwarding #4159

merged 2 commits into from
Oct 14, 2019

Conversation

gregw
Copy link
Contributor

@gregw gregw commented Oct 5, 2019 •
edited

Fix for #4156 :

  • check validity of sessions in getSession(SessionHandler)
  • do not replace session in doScope if SessionHandler is the same.

joakime and others added 2 commits October 4, 2019 11:08
@joakime
Issue #4156 - Adding test to replicate issue
50d7b8c 
Signed-off-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
@gregw
Issue #4156 Session already in cache
8b08b0f 
+ check validity of sessions in getSession(SessionHandler)
+ do not replace session in doScope if SessionHandler is the same.

Signed-off-by: Greg Wilkins <gregw@webtide.com>
@gregw gregw added this to In progress in Jetty 9.4.22 via automation Oct 5, 2019
@joakime joakime changed the title Jetty 9.4.x 4156 session already in cache Issue #4156 - Session Already in Cache during forwarding Oct 6, 2019
@joakime joakime mentioned this pull request Oct 6, 2019
Closed
Jetty 9.4.22 automation moved this from In progress to Reviewer approved Oct 7, 2019
janbartel
janbartel approved these changes Oct 7, 2019
View reviewed changes
Copy link
Contributor

@janbartel janbartel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

joakime
joakime approved these changes Oct 9, 2019
View reviewed changes
Copy link
Contributor

@joakime joakime left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gregw gregw merged commit f09e03c into jetty-9.4.x Oct 14, 2019
Jetty 9.4.22 automation moved this from Reviewer approved to Done Oct 14, 2019
@gregw gregw deleted the jetty-9.4.x-4156-session-already-in-cache branch October 14, 2019 00:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joakime joakime joakime approved these changes

@janbartel janbartel janbartel approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Jetty 9.4.22
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gregw @joakime @janbartel