Jetty 12.1.x jetty ee web xml #11746
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregw
approved these changes
May 3, 2024
There was a problem hiding this comment.
I couple of niggles.
Also, I think we need to ponder what to do with jetty-web.xml files? Warn if we find them? Perhaps warn if there is another jetty-eeX-web.xml that doesn't match?
Or maybe we make a EeContextHandler class that sits between the EEX impls and ContextHandler and warn only if a jetty-web.xml contains anything but the configuration for that common subclass.
Eitherway, this is good enough for us to commit to 12.1.x and get on with updating the demos to use it.
...tty-ee10-webapp/src/test/resources/webapp-with-jetty-ee10-web-xml/WEB-INF/jetty-ee10-web.xml
Outdated
Show resolved
Hide resolved
...10/jetty-ee10-webapp/src/test/resources/webapp-with-jetty-ee10-web-xml/WEB-INF/jetty-web.xml
Outdated
Show resolved
Hide resolved
jetty-ee10/jetty-ee10-webapp/src/test/resources/webapp-with-jetty-web-xml/WEB-INF/jetty-web.xml
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Check for a
WEB-INF/jetty-eeX-web.xmlbefore checking forWEB-INF/jetty-web.xml.