Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #11699 - ISE when Response does not exist. #11700

Merged
merged 1 commit into from Apr 26, 2024

Conversation

joakime
Copy link
Contributor

@joakime joakime commented Apr 25, 2024

Give a more clear Exception for applications and libraries that are doing improper things with request / response lifecycle.

Fixes: #11699

@joakime joakime self-assigned this Apr 25, 2024
@joakime joakime requested review from gregw and lorban April 25, 2024 15:16
@joakime joakime added the Bug For general bugs on Jetty side label Apr 25, 2024
Copy link
Contributor

@lorban lorban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, throwing ISE with a reasonable error message is always clearer than NPE.

@joakime joakime merged commit 7da9056 into jetty-12.0.x Apr 26, 2024
10 checks passed
@joakime joakime deleted the fix/12.0.x/npe-response-recycled branch April 26, 2024 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug For general bugs on Jetty side
Projects
No open projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

new IllegalStateException when attempting to access Request/Response outside of Request Lifecycle
3 participants