Issue #11322 Upgrade to mongodb-driver-sync 5.x #11681
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
olamy
force-pushed
the
jetty-12.0.x-mongodb-driver-sync
branch
from
dcb8d8a
to
bb593bd
Compare
janbartel
reviewed
Apr 23, 2024
| @@ -181,17 +182,18 @@ public SessionData doLoad(String id) throws Exception | |||
| if (sessionDocument == null) | |||
| return null; | |||
|
|
|||
| Boolean valid = (Boolean)sessionDocument.get(__VALID); | |||
| boolean valid = (Boolean)sessionDocument.get(__VALID); | |||
There was a problem hiding this comment.
If sessionDocument doesn't contain the __VALID field, this will throw NPE.
|
|
||
| DBObject sessionDocument = _dbSessions.findOne(new BasicDBObject(__ID, id), fields); | ||
| Bson filterId = Filters.eq(__ID, id); | ||
| Document sessionDocument = _dbSessions.find(filterId).first(); |
There was a problem hiding this comment.
I think the old code was trying to be efficient about the fields that we returned, ie only returning the fields that would be examined, rather than the whole set of serialized session attributes (which won't be examined). Does the new API provide a similar efficiency?
| @@ -332,48 +335,37 @@ public boolean doExists(String id) throws Exception | |||
| Long expiry = (Long)sessionDocument.get(__EXPIRY); | |||
|
|
|||
| //expired? | |||
| if (expiry.longValue() > 0 && expiry.longValue() < System.currentTimeMillis()) | |||
| if (expiry > 0 && expiry < System.currentTimeMillis()) | |||
There was a problem hiding this comment.
Won't this throw NPE if expiry is null ?
| @@ -487,12 +495,12 @@ public void doStore(String id, SessionData data, long lastSaveTime) throws Excep | |||
| sets.put(getContextSubfield(__LASTNODE), data.getLastNode()); | |||
| version = ((Number)version).longValue() + 1L; | |||
| ((NoSqlSessionData)data).setVersion(version); | |||
| update.put("$inc", _version1); | |||
| //update.put("$inc", _version1); | |||
There was a problem hiding this comment.
We need to update the version stored in the session document.
| @@ -458,8 +466,8 @@ public void initialize(SessionContext context) throws Exception | |||
| public void doStore(String id, SessionData data, long lastSaveTime) throws Exception | |||
| { | |||
| // Form query for upsert | |||
| final BasicDBObject key = new BasicDBObject(__ID, id); | |||
|
|
|||
| //final BasicDBObject key = new BasicDBObject(__ID, id); | |||
There was a problem hiding this comment.
Are we sure that mongo hasn't changed the way it stores documents? In other words, we need to check that a session written out by the older version of mongo is still readable by this new version of mongo.
olamy
force-pushed
the
jetty-12.0.x-mongodb-driver-sync
branch
from
bb593bd
to
f134d84
Compare
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
jetty-12.0.x-mongodb-driver-sync
branch
from
f134d84
to
5482e74
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.