Customizable error page buffer size

[dkaukov]

Ability to increase buffer size past 8k in the custom ErrorHandler

[joakime]

The HttpConfiguration is how you control the output buffer size.

What is the use case for this?

[dkaukov]

True, but

    bufferSize = Math.min(8192, bufferSize); // TODO ?

limiting it to the 8k. We need a way to increase the limit.

[joakime]

limiting it to the 8k. We need a way to increase the limit.

I understand that you want to increase the buffer size limit, but why?
What's the use case for a larger buffer size? (I ask, as there's probably several different ways to accomplish your use case without increasing this specific buffer size)

[dkaukov]

Hi, In the

@Override
protected void writeErrorHtml(Request request, Writer writer, Charset charset, int code, String message, Throwable cause, boolean showStacks) throws IOException {
  ....
}

we are generating custom error page using Writer. Something like:

  themeLeafTemplate.execute(writer, errorInfo);

If error page is bigger than buffer size it is just trimmed.

[joakime]

Need to dig into why we are doing this via a static sized buffer.

I would like to see if this need can be accomplished via a Writer created with the Content.Sink features instead. (will try this in a different branch soon)