Fix #10805 zero dynamic table (#11445) #11452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: gregw <gregw@webtide.com>
|
@gregw the test is not testing the changes made in |
|
@lachlan-roberts yeah that's a known issue with the tests. I checked the change with Wireshark on the tests. Add this originated in 9.4 U didn't want to spend time in a full test. I'll make a test that actually checks the issue when this is merged to 12 |
sbordet
approved these changes
Feb 28, 2024
lachlan-roberts
approved these changes
Feb 28, 2024
gregw
added a commit
that referenced
this pull request
Feb 28, 2024
* Fix #10805 zero dynamic table (#11445) * Added test for #10805 Zero Dynamic Table * fixed file header * Added test for #10805 Zero Dynamic Table * Fix for #10805 Zero Dynamic Table Set the correct default size for the table. Always send the max table size on the first encode * updated file header Signed-off-by: gregw <gregw@webtide.com> --------- Signed-off-by: gregw <gregw@webtide.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11445
Added test for Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0 #10805 Zero Dynamic Table
fixed file header
Added test for Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0 #10805 Zero Dynamic Table
Fix for Jetty response with an invalid HTTP2 packet if the client set the hpack table size as 0 #10805 Zero Dynamic Table
Set the correct default size for the table.
Always send the max table size on the first encode