fix possible empty coverage report and avoid storing too many data non needed #11023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joakime
previously approved these changes
Dec 6, 2023
|
holding up this a bit as I'd like to test with jdk21 as well |
olamy
force-pushed
the
jetty-12.0.x-fix-possible-empty-coverage-report
branch
from
df2b2b4
to
330b229
Compare
olamy
force-pushed
the
jetty-12.0.x-fix-possible-empty-coverage-report
branch
from
330b229
to
20374e8
Compare
|
@olamy are you done testing this with jdk21 yet? |
|
Not exactly. I figured out jacoco doesn't produce same output for 17 and 21 :( |
…n needed Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
Signed-off-by: Olivier Lamy <olamy@apache.org>
olamy
force-pushed
the
jetty-12.0.x-fix-possible-empty-coverage-report
branch
from
20374e8
to
66ce691
Compare
|
This seems out of date |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Olivier Lamy olamy@apache.org