implement servlet upgrade for ee10 #10128
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove lambda for clarity
removed unused variable
Requests are always handled by ServletHandler, one way or another.
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Servlet upgrade
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Jul 19, 2023
jetty-core/jetty-server/src/main/java/org/eclipse/jetty/server/internal/HttpChannelState.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
lachlan-roberts
commented
Jul 20, 2023
| // Do not use SerializedInvoker here because application code running within | ||
| // SerializedInvoker could issue blocking write() or close() that would deadlock. | ||
| // We must execute in case of recursive write within the callback. | ||
| getRequest().getContext().execute(() -> callback.failed(x)); |
There was a problem hiding this comment.
@sbordet I don't like this, but we have a test which calls write from within the callback which results in recursion and a StackOverflowError if we execute the callback directly.
gregw
force-pushed
the
experiment/jetty-12-ServletChannel-cleanup
branch
from
ee383a2
to
3d24929
Compare
Base automatically changed from
experiment/jetty-12-ServletChannel-cleanup
to
jetty-12.0.x
August 15, 2023 10:02
…tty-12-ServletChannel-cleanup-ee10-servlet-upgrade
Signed-off-by: Lachlan Roberts <lachlan@webtide.com>
gregw
requested changes
Aug 21, 2023
| // Do not use SerializedInvoker here because application code running within | ||
| // SerializedInvoker could issue blocking write() or close() that would deadlock. | ||
| // We must execute in case of recursive write within the callback. | ||
| getRequest().getContext().execute(callback::succeeded); |
There was a problem hiding this comment.
We cannot have an execute on the callback of every write. This is a blocker. Let's analyse after 12.0.1 and see how we can avoid t his.
…tty-12-ServletChannel-cleanup-ee10-servlet-upgrade
gregw
requested changes
Oct 3, 2023
…tty-12-ServletChannel-cleanup-ee10-servlet-upgrade
…tty-12-ServletChannel-cleanup-ee10-servlet-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implementing ee10 servlet upgrade for PR #10064